Add define for ADIOS2_HAVE_BP5 #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
fix-adios2-have-bp5-define
branch
from
b2d291c
to
c676711
Compare
This was removed from ADIOS2 v2.9 to v2.10.
franzpoeschel
force-pushed
the
fix-adios2-have-bp5-define
branch
from
c676711
to
9bf8591
Compare
franzpoeschel
added a commit
to franzpoeschel/picongpu
that referenced
this pull request
Apr 25, 2024
Fixed in openPMD-api by openPMD/openPMD-api#1614. Versions that don't have this fix will get confused and hand down their confusion to PIConGPU.
franzpoeschel
added a commit
to franzpoeschel/picongpu
that referenced
this pull request
Apr 26, 2024
Fixed in openPMD-api by openPMD/openPMD-api#1614. Versions that don't have this fix will get confused and hand down their confusion to PIConGPU.
ikbuibui
pushed a commit
to ikbuibui/picongpu
that referenced
this pull request
Apr 30, 2024
Fixed in openPMD-api by openPMD/openPMD-api#1614. Versions that don't have this fix will get confused and hand down their confusion to PIConGPU.
ikbuibui
pushed a commit
to ikbuibui/picongpu
that referenced
this pull request
Apr 30, 2024
Fixed in openPMD-api by openPMD/openPMD-api#1614. Versions that don't have this fix will get confused and hand down their confusion to PIConGPU.
|
I accidentally merged this somehow, @ax3l will revert the merge commit and we'll try this once more. |
franzpoeschel
commented
May 7, 2024
| @@ -19,6 +19,11 @@ | |||
| #define openPMD_HAS_ADIOS_2_9 \ | |||
| (ADIOS2_VERSION_MAJOR * 100 + ADIOS2_VERSION_MINOR >= 209) | |||
|
|
|||
| #if !defined(ADIOS2_HAVE_BP5) && openPMD_HAS_ADIOS_2_9 | |||
| // ADIOS2 v2.10 no longer defines this | |||
| #define ADIOS2_HAVE_BP5 | |||
There was a problem hiding this comment.
todo: define our own macro instead of this
ax3l
reviewed
May 7, 2024
| @@ -19,6 +19,11 @@ | |||
| #define openPMD_HAS_ADIOS_2_9 \ | |||
| (ADIOS2_VERSION_MAJOR * 100 + ADIOS2_VERSION_MINOR >= 209) | |||
|
|
|||
| #if !defined(ADIOS2_HAVE_BP5) && openPMD_HAS_ADIOS_2_9 | |||
| // ADIOS2 v2.10 no longer defines this | |||
| #define ADIOS2_HAVE_BP5 | |||
There was a problem hiding this comment.
Let's call this openPMD_HAS_ADIOS_BP5 and add all logic here (and rename other uses).
FilipO28555
pushed a commit
to FilipO28555/picongpu
that referenced
this pull request
May 9, 2024
Fixed in openPMD-api by openPMD/openPMD-api#1614. Versions that don't have this fix will get confused and hand down their confusion to PIConGPU.
FilipO28555
pushed a commit
to FilipO28555/picongpu
that referenced
this pull request
May 13, 2024
Fixed in openPMD-api by openPMD/openPMD-api#1614. Versions that don't have this fix will get confused and hand down their confusion to PIConGPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed from ADIOS2 v2.9 to v2.10, causing test failures in #1613 since openPMD thinks that BP5 does not exist, but ADIOS2 creates BP5 files.